Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lro in disable and enable cdn https #19180

Merged
merged 5 commits into from
May 25, 2022
Merged

Fix lro in disable and enable cdn https #19180

merged 5 commits into from
May 25, 2022

Conversation

ChenglongLiu
Copy link
Member

@ChenglongLiu ChenglongLiu commented May 23, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ChenglongLiu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2066:7
    Old: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2066:7
    ❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2133:7
    Old: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2129:7
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2065
    ⚠️ R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L2132


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3264
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3264
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3264
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3310
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3310
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3310
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3341
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3363
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3363
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3363
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3416
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3416
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3416
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3473
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3473
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3473
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3526
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3526
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3526
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3583
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3583
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3583
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3636
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3636
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3636
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3642
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3642
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Cdn/stable/2021-06-01/cdn.json#L3642
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 23, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - Approved - 12.0.0
    +	Removed operation CustomDomainsOperations.disable_custom_https
+	Removed operation CustomDomainsOperations.enable_custom_https
    ❌azure-sdk-for-go - cdn/mgmt/2021-06-01/cdn - v65.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
+	Type of `CustomDomainProperties.ProvisioningState` has been changed from `*string` to `CustomHTTPSProvisioningState`
+	Type of `EndpointProperties.ProvisioningState` has been changed from `*string` to `EndpointProvisioningState`
+	Type of `OriginGroupProperties.ProvisioningState` has been changed from `*string` to `OriginGroupProvisioningState`
+	Type of `OriginProperties.ProvisioningState` has been changed from `*string` to `OriginProvisioningState`
+	Type of `ProfileProperties.ProvisioningState` has been changed from `*string` to `ProfileProvisioningState`
+	Type of `ResourceUsage.Unit` has been changed from `*string` to `ResourceUsageUnit`
    ❌azure-sdk-for-go - cdn/mgmt/2020-09-01/cdn - v65.0.0
    +	Type of `AFDOriginProperties.SharedPrivateLinkResource` has been changed from `interface{}` to `*SharedPrivateLinkResourceProperties`
+	Type of `AFDOriginUpdatePropertiesParameters.SharedPrivateLinkResource` has been changed from `interface{}` to `*SharedPrivateLinkResourceProperties`
+	Type of `RouteProperties.CompressionSettings` has been changed from `interface{}` to `*CompressionSettings`
+	Type of `RouteUpdatePropertiesParameters.CompressionSettings` has been changed from `interface{}` to `*CompressionSettings`
    ❌azure-sdk-for-go - cdn/mgmt/2020-04-15/cdn - v65.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    ❌azure-sdk-for-go - cdn/mgmt/2019-06-15/cdn - v65.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    ❌azure-sdk-for-go - cdn/mgmt/2019-04-15/cdn - v65.0.0
    +	Function `CustomDomainsClient.DisableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.DisableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsDisableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPSSender` return value(s) have been changed from `(*http.Response, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
+	Function `CustomDomainsClient.EnableCustomHTTPS` return value(s) have been changed from `(CustomDomain, error)` to `(CustomDomainsEnableCustomHTTPSFuture, error)`
    ️✔️azure-sdk-for-go - cdn/mgmt/2017-10-12/cdn - v65.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2017-04-02/cdn - v65.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2016-10-02/cdn - v65.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2016-04-02/cdn - v65.0.0
    ️✔️azure-sdk-for-go - cdn/mgmt/2015-06-01/cdn - v65.0.0
    ❌azure-sdk-for-js - @azure/arm-cdn - Approved - 8.0.0
    +	Removed operation CustomDomains.disableCustomHttps
+	Removed operation CustomDomains.enableCustomHttps
    ❌azure-sdk-for-go-track2 - armcdn - 2.0.0
    +	Function `*CustomDomainsClient.DisableCustomHTTPS` has been removed
+	Function `*CustomDomainsClient.EnableCustomHTTPS` has been removed
+	Struct `CustomDomainsClientDisableCustomHTTPSOptions` has been removed
+	Struct `CustomDomainsClientEnableCustomHTTPSOptions` has been removed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.10.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.10.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.10.0` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation CustomDomainsOperations.begin_disable_custom_https
info	[Changelog]   - Added operation CustomDomainsOperations.begin_enable_custom_https
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Removed operation CustomDomainsOperations.disable_custom_https
info	[Changelog]   - Removed operation CustomDomainsOperations.enable_custom_https
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-cdn-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️cdn/mgmt/2021-06-01/cdn [View full logs]  [Release SDK Changes]
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - New const `OriginGroupProvisioningStateFailed`
info	[Changelog] - New function `PossibleEndpointProvisioningStateValues() []EndpointProvisioningState`
info	[Changelog] - New function `PossibleProfileProvisioningStateValues() []ProfileProvisioningState`
info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleOriginProvisioningStateValues() []OriginProvisioningState`
info	[Changelog] - New function `PossibleOriginGroupProvisioningStateValues() []OriginGroupProvisioningState`
info	[Changelog] - New function `PossibleResourceUsageUnitValues() []ResourceUsageUnit`
info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 32 additive change(s).
    • ️✔️cdn/mgmt/2020-09-01/cdn [View full logs] 
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - Type of `RouteProperties.CompressionSettings` has been changed from `interface{}` to `*CompressionSettings`
info	[Changelog] - Type of `AFDOriginUpdatePropertiesParameters.SharedPrivateLinkResource` has been changed from `interface{}` to `*SharedPrivateLinkResourceProperties`
info	[Changelog] - Type of `AFDOriginProperties.SharedPrivateLinkResource` has been changed from `interface{}` to `*SharedPrivateLinkResourceProperties`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `TransformTrim`
info	[Changelog] - New const `TransformRemoveNulls`
info	[Changelog] - New const `TransformURLEncode`
info	[Changelog] - New const `TransformURLDecode`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 4 additive change(s).
    • ️✔️cdn/mgmt/2020-04-15/cdn [View full logs] 
      Only show 12 items here, please refer to log for details.
      info	[Changelog] - New const `URLDecode`
info	[Changelog] - New const `RemoveNulls`
info	[Changelog] - New const `URLEncode`
info	[Changelog] - New const `Trim`
info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*CustomDomainProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
info	[Changelog] - New field `CustomHTTPSParameters` in struct `CustomDomainProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 12 additive change(s).
    • ️✔️cdn/mgmt/2019-06-15/cdn [View full logs] 
      Only show 12 items here, please refer to log for details.
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `Trim`
info	[Changelog] - New const `URLEncode`
info	[Changelog] - New const `URLDecode`
info	[Changelog] - New const `RemoveNulls`
info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 10 additive change(s).
    • ️✔️cdn/mgmt/2019-04-15/cdn [View full logs] 
      Only show 12 items here, please refer to log for details.
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `Trim`
info	[Changelog] - New const `URLDecode`
info	[Changelog] - New const `URLEncode`
info	[Changelog] - New const `RemoveNulls`
info	[Changelog] - New function `*CustomDomainsDisableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*CustomDomainsEnableCustomHTTPSFuture.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `CustomDomainsDisableCustomHTTPSFuture`
info	[Changelog] - New struct `CustomDomainsEnableCustomHTTPSFuture`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 10 additive change(s).
    • ️✔️cdn/mgmt/2017-10-12/cdn [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️cdn/mgmt/2017-04-02/cdn [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️cdn/mgmt/2016-10-02/cdn [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️cdn/mgmt/2016-04-02/cdn [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️cdn/mgmt/2015-06-01/cdn [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*CustomDomainsClient.DisableCustomHTTPS` has been removed
info	[Changelog] - Function `*CustomDomainsClient.EnableCustomHTTPS` has been removed
info	[Changelog] - Struct `CustomDomainsClientDisableCustomHTTPSOptions` has been removed
info	[Changelog] - Struct `CustomDomainsClientEnableCustomHTTPSOptions` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `*CustomDomainsClient.BeginDisableCustomHTTPS(context.Context, string, string, string, string, *CustomDomainsClientBeginDisableCustomHTTPSOptions) (*runtime.Poller[CustomDomainsClientDisableCustomHTTPSResponse], error)`
info	[Changelog] - New function `*CustomDomainsClient.BeginEnableCustomHTTPS(context.Context, string, string, string, string, *CustomDomainsClientBeginEnableCustomHTTPSOptions) (*runtime.Poller[CustomDomainsClientEnableCustomHTTPSResponse], error)`
info	[Changelog] - New struct `CustomDomainsClientBeginDisableCustomHTTPSOptions`
info	[Changelog] - New struct `CustomDomainsClientBeginEnableCustomHTTPSOptions`
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 6 additive change(s).
    ️❌ azure-sdk-for-net failed [Detail]
    • ❌Failed [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cdn/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation CustomDomains.beginDisableCustomHttps
info	[Changelog]   - Added operation CustomDomains.beginDisableCustomHttpsAndWait
info	[Changelog]   - Added operation CustomDomains.beginEnableCustomHttps
info	[Changelog]   - Added operation CustomDomains.beginEnableCustomHttpsAndWait
info	[Changelog]   - Added Type Alias EndpointProvisioningState
info	[Changelog]   - Added Type Alias OriginGroupProvisioningState
info	[Changelog]   - Added Type Alias OriginProvisioningState
info	[Changelog]   - Added Type Alias ProfileProvisioningState
info	[Changelog]   - Added Type Alias ResourceUsageUnit
info	[Changelog]   - Interface CustomDomainsDisableCustomHttpsOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface CustomDomainsDisableCustomHttpsOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface CustomDomainsEnableCustomHttpsOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface CustomDomainsEnableCustomHttpsOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Added Enum KnownEndpointProvisioningState
info	[Changelog]   - Added Enum KnownOriginGroupProvisioningState
info	[Changelog]   - Added Enum KnownOriginProvisioningState
info	[Changelog]   - Added Enum KnownProfileProvisioningState
info	[Changelog]   - Added Enum KnownResourceUsageUnit
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation CustomDomains.disableCustomHttps
info	[Changelog]   - Removed operation CustomDomains.enableCustomHttps
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from fa7c536. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️cdn [View full logs] 
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from fa7c536. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ChenglongLiu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @ChenglongLiu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @azure-sdk azure-sdk mentioned this pull request May 23, 2022
    Closed
    This was referenced May 23, 2022
    Closed
    Closed
    Closed
    Closed
    @ChenglongLiu ChenglongLiu marked this pull request as draft May 23, 2022 13:13
    @ChenglongLiu ChenglongLiu marked this pull request as ready for review May 24, 2022 00:19
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 24, 2022
    @xiaoxuqi-ms
    Copy link
    Member

    @qiaozha @msyyc @ArcturusZhang Please help to review the breaking change in SDK

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-sdk azure-sdk mentioned this pull request May 25, 2022
    Closed
    @xiaoxuqi-ms xiaoxuqi-ms merged commit fa7c536 into Azure:main May 25, 2022
    This was referenced May 25, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    gargankit-microsoft pushed a commit that referenced this pull request May 26, 2022
    @ChenglongLiu @gargankit-microsoft
    Fix lro in disable and enable cdn https (#19180)
    344cbb8 
    * Fix lro in disable and enable cdn https

* Update the examples

* Update the examples

* Update the examples

* Update the examples

Co-authored-by: Chenglong Liu <chengll@microsoft.com>
    @MaryGao MaryGao mentioned this pull request Nov 29, 2022
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @xiaoxuqi-ms xiaoxuqi-ms xiaoxuqi-ms approved these changes

    @jorinmejia jorinmejia jorinmejia approved these changes

    @yunheMsft yunheMsft Awaiting requested review from yunheMsft

    @t-bzhan t-bzhan Awaiting requested review from t-bzhan

    Assignees

    @xiaoxuqi-ms xiaoxuqi-ms

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go-V2 Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @ChenglongLiu @xiaoxuqi-ms @ArcturusZhang @jorinmejia @JeffreyRichter @qiaozha @msyyc